-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add organization artifact metadata APIs #3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add organization artifact metadata APIs #3944
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
- Coverage 92.45% 92.41% -0.05%
==========================================
Files 203 204 +1
Lines 14980 15025 +45
==========================================
+ Hits 13850 13885 +35
- Misses 927 932 +5
- Partials 203 208 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gmlewis Sir can you please review the code? |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @maishivamhoo123, @alexandear , and @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @zyfy29
…github final changes
|
@Not-Dhananjay-Mishra can you please check once i think the latest pr is able to meet all your requirements? |
| // GitHub API docs: https://docs.github.com/rest/orgs/artifact-metadata#create-an-artifact-deployment-record | ||
| // | ||
| //meta:operation POST /orgs/{org}/artifacts/metadata/deployment-record | ||
| func (s *OrganizationsService) CreateArtifactDeploymentRecord(ctx context.Context, org string, record *ArtifactDeploymentRecord) (*ArtifactDeploymentResponse, *Response, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maishivamhoo123 this comment is not addressed: https://github.com/google/go-github/pull/3944/changes#r2732556939
Should be a separate struct for the request body.
Description
This PR implements the Organization Artifact Metadata APIs as requested in #3917.
This version corrects the scope from Repository to Organization level.
Changes
github/orgs_artifacts.go.POST /orgs/{org}/artifacts/metadata/deployment-recordPOST /orgs/{org}/artifacts/metadata/deployment-record/cluster/{cluster}POST /orgs/{org}/artifacts/metadata/storage-recordGET /orgs/{org}/artifacts/{subject_digest}/metadata/deployment-recordsGET /orgs/{org}/artifacts/{subject_digest}/metadata/storage-recordsgithub/orgs_artifacts_test.go.github-accessors.goandgithub-stringify_test.goviascript/generate.sh.Checklist
script/test.sh).script/lint.sh).script/generate.sh.Fixes #3917