feat: Add GitHub Enterprise App installation repository management APIs by nithish-95 · Pull Request #3831 · google/go-github

nithish-95 · 2025-11-16T08:17:38Z

Description

Implements enterprise GitHub App installation repository management endpoints for issue #3829.

This PR adds the following endpoints:

GET /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories
PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories
PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories/add
PATCH /enterprises/{enterprise}/apps/organizations/{org}/installations/{installation_id}/repositories/remove

Changes

Added ListRepositoriesForOrgInstallation method to list repositories accessible to an app installation
Added ToggleInstallationRepositories method to update repository selection
Added AddRepositoriesToInstallation method to add repositories to an installation
Added RemoveRepositoriesFromInstallation method to remove repositories from an installation
Added corresponding test cases for all methods
Added necessary request/response types

Testing

All unit tests pass
Linter checks pass
Follows existing code patterns in the repository

cc @gmlewis @Not-Dhananjay-Mishra

github/enterprise_apps.go

codecov · 2025-11-16T12:30:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (3afe183) to head (5d9326e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3831      +/-   ##
==========================================
+ Coverage   92.42%   92.44%   +0.02%     
==========================================
  Files         197      198       +1     
  Lines       14167    14210      +43     
==========================================
+ Hits        13094    13137      +43     
  Misses        884      884              
  Partials      189      189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Thank you, @nithish-95!
One minor tweak, please, then we should be ready to merge after a second LGTM+Approval from any other contributor to this repo.

cc: @stevehipwell - @alexandear - @zyfy29

github/enterprise_apps.go

stevehipwell · 2025-11-18T14:22:20Z

How does this PR relate to #3830? They look related to me, which means we likely want to align the implementation including naming. Would it not make sense to wait for #3830 to be merged before reviewing this PR?

nithish-95 · 2025-11-23T05:14:23Z

I've rebased on master to use the existing AccessibleRepository struct and removed the duplicate definition from this PR.
I also updated ListRepositoriesForOrgInstallation to return []*AccessibleRepository and fixed ToggleInstallationRepositories to return *Installation as requested.

I feel sorry for the way I use Git!!

cc: @gmlewis - @Not-Dhananjay-Mishra - @stevehipwell

gmlewis

Thank you, @nithish-95!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra

github/enterprise_apps.go

stevehipwell

I've added some naming suggestions, happy to discuss the "why".

github/enterprise_apps.go

nithish-95 · 2025-11-25T21:37:06Z

I've added some naming suggestions, happy to discuss the "why".

@stevehipwell Yes, Please!

stevehipwell · 2025-11-25T21:53:49Z

@nithish-95 which parts of the review did you want to discuss?

nithish-95 · 2025-11-27T01:39:47Z

@nithish-95 which parts of the review did you want to discuss?

Hi @stevehipwell , I'm making those updates.

Could you briefly explain the rationale behind these specific suggestions? I'm particularly interested in the conventions for type scoping for Enterprise prefixing and the preferred usage of AppInstallation vs Installation.

- Use EnterpriseService instead of creating new service - Add EnterpriseInstallationRepositoriesOptions for consistency - Update method signatures to Required

…orOrgInstallation` to return a slice of it

…tead of ListRepositories and adjust its test expectations.

github/enterprise_apps.go

stevehipwell · 2025-11-28T17:25:28Z

@nithish-95 check out the naming sections in the Google Go Style guide and the Google Go Style Decisions.

…se app repository functions and tests

Not-Dhananjay-Mishra

Thanks @nithish-95
LGTM.

gmlewis · 2025-11-29T12:01:49Z

Thank you, @Not-Dhananjay-Mishra!

@stevehipwell - have your comments been addressed to your satisfaction and is this ready to merge?

stevehipwell

LGTM

gmlewis · 2025-12-02T13:05:06Z

Thank you, @stevehipwell!
Merging.

Not-Dhananjay-Mishra reviewed Nov 16, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

Not-Dhananjay-Mishra reviewed Nov 16, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

Not-Dhananjay-Mishra reviewed Nov 16, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

gmlewis requested changes Nov 17, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 17, 2025

Not-Dhananjay-Mishra suggested changes Nov 17, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

github/enterprise_apps.go Outdated Show resolved Hide resolved

github/enterprise_apps.go Outdated Show resolved Hide resolved

github/enterprise_apps.go Outdated Show resolved Hide resolved

nithish-95 force-pushed the issues-3829-p2 branch from 915cfbf to da913d0 Compare November 23, 2025 03:35

nithish-95 requested review from Not-Dhananjay-Mishra and gmlewis November 23, 2025 04:11

nithish-95 force-pushed the issues-3829-p2 branch from 0173838 to 1a69bbf Compare November 23, 2025 04:40

gmlewis approved these changes Nov 24, 2025

View reviewed changes

Not-Dhananjay-Mishra suggested changes Nov 24, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

github/enterprise_apps.go Outdated Show resolved Hide resolved

stevehipwell suggested changes Nov 24, 2025

View reviewed changes

nithish-95 added 6 commits November 27, 2025 19:02

feat: add enterprise app installation repository endpoints;

3a5cc2b

fix: resolve linter issues from script/lint.sh

aa48a27

fix: address code review feadback

3b1b3c4

- Use EnterpriseService instead of creating new service - Add EnterpriseInstallationRepositoriesOptions for consistency - Update method signatures to Required

feat: add AccessibleRepository struct and update `ListRepositoriesF…

fc00e8e

…orOrgInstallation` to return a slice of it

fix: update ToggleInstallationRepositories to return Installation ins…

1e52265

…tead of ListRepositories and adjust its test expectations.

feat: Add enterprise app installation repository management APIs

9b5e78a

nithish-95 force-pushed the issues-3829-p2 branch from 1a69bbf to 9b5e78a Compare November 28, 2025 03:27

nithish-95 requested review from Not-Dhananjay-Mishra and stevehipwell November 28, 2025 03:31

Not-Dhananjay-Mishra suggested changes Nov 28, 2025

View reviewed changes

github/enterprise_apps.go Outdated Show resolved Hide resolved

github/enterprise_apps.go Outdated Show resolved Hide resolved

github/enterprise_apps.go Outdated Show resolved Hide resolved

refactor: change options parameters from pointer to value in enterpri…

5d9326e

…se app repository functions and tests

nithish-95 requested a review from Not-Dhananjay-Mishra November 29, 2025 06:59

Not-Dhananjay-Mishra approved these changes Nov 29, 2025

View reviewed changes

stevehipwell approved these changes Dec 2, 2025

View reviewed changes

gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 2, 2025

gmlewis merged commit b480d82 into google:master Dec 2, 2025
7 checks passed

gmlewis mentioned this pull request Dec 4, 2025

Bump version of go-github to v80.0.0 #3854

Merged

Comments

Conversation

nithish-95 commented Nov 16, 2025

Description

Changes

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevehipwell commented Nov 18, 2025

Uh oh!

nithish-95 commented Nov 23, 2025

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nithish-95 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevehipwell commented Nov 25, 2025

Uh oh!

nithish-95 commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevehipwell commented Nov 28, 2025

Uh oh!

Not-Dhananjay-Mishra left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Nov 29, 2025

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 16, 2025 •

edited

Loading

nithish-95 commented Nov 25, 2025 •

edited

Loading

nithish-95 commented Nov 27, 2025 •

edited

Loading