feat: Add two new Secret Scanning API endpoints#3687
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
==========================================
+ Coverage 91.36% 91.37% +0.01%
==========================================
Files 187 187
Lines 16734 16760 +26
==========================================
+ Hits 15289 15315 +26
Misses 1257 1257
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@alexandear Thanks for the suggestions. I have changed the method names. Please let me know if you have any other suggestions. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra.
This is a good start. Please address the findings and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
|
Thanks @gmlewis for the feedback! I have fixed all the findings. Sorry for the extra back and forth code review. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Just FYI - suddenly I have lost write access to this repo, like in #3689... so I can no longer approve the workflows and need to find out what is going on... this may take some time to resolve... I apologize for the inconvenience. |
|
@alexandear - do you now approve this PR for merging? |
|
@alexandear i have done some changes can u please check them. |
|
@Not-Dhananjay-Mishra - please fix the linter and test failures and push the changes to this PR. |
|
@gmlewis all fixed |
|
Thank you, @Not-Dhananjay-Mishra and @alexandear! |
This PR adds support for two new Secret Scanning API endpoints that are currently missing from the
go-githublibraryImplement
POST /repos/{owner}/{repo}/secret-scanning/push-protection-bypassesGET /repos/{owner}/{repo}/secret-scanning/scan-historyChanges
CreatePushProtectionBypassmethodGetScanHistorymethodPushProtectionBypassesmethod -PushProtectionBypassRequestandPushProtectionBypassScanHistorymethod -Scan,CustomPatternScanandSecretScanningResponseIssue - #3686