Skip to content

Conversation

@austinvhuang
Copy link
Contributor

@austinvhuang austinvhuang commented Mar 11, 2024

Will retarget this PR to dev once the examples branch PR merges to dev. #82 already was already large enough, these changes are left as a follow-up for now.

  • Move command line argument definitions out of the gemma.h interface (to app.h)
  • Fix off-by-1 printing of "." for prefill tokens
  • Update libgemma commit hash for hello_world

@google google deleted a comment from Zeenat30 Mar 12, 2024
@google google deleted a comment from Zeenat30 Mar 12, 2024
@austinvhuang austinvhuang changed the base branch from examples to dev March 12, 2024 19:12
@austinvhuang austinvhuang marked this pull request as ready for review March 12, 2024 19:13
@austinvhuang austinvhuang changed the title [WIP / Draft - Do Not Merge] - Additional cleanup after libgemma refactor https://github.com/google/gemma.cpp/pull/82 Additional cleanup after libgemma refactor https://github.com/google/gemma.cpp/pull/82 Mar 12, 2024
@austinvhuang austinvhuang requested a review from pculliton March 12, 2024 20:32
Copy link
Collaborator

@pculliton pculliton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@austinvhuang austinvhuang added the copybara-import Trigger Copybara for merging pull requests label Mar 12, 2024
@copybara-service copybara-service bot merged commit 0221956 into dev Mar 12, 2024
@austinvhuang austinvhuang deleted the refactor-tidy branch March 13, 2024 16:38
@Zeenat30
Copy link

Screenshot_20240314_215353_Chrome
Uploading Screenshot_20240311_222016_Chrome.jpg…

@Zeenat30
Copy link

Now this is facts theft is theft ask permission at least I was working on another project with my api

@jan-wassenberg
Copy link
Member

I see a screenshot that appears to have nothing to do with this Gemma.cpp repository. Further such comments will be reported and deleted.

@google google deleted a comment from Zeenat30 Mar 29, 2024
@google google deleted a comment from Zeenat30 Mar 29, 2024
@google google deleted a comment from Zeenat30 Jul 22, 2024
@google google deleted a comment from Zeenat30 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara-import Trigger Copybara for merging pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants