Skip to content

Require at least v0.14.0 of future. Added travis config.#2

Merged
gkovacs merged 2 commits intogkovacs:masterfrom
ewels:master
May 18, 2017
Merged

Require at least v0.14.0 of future. Added travis config.#2
gkovacs merged 2 commits intogkovacs:masterfrom
ewels:master

Conversation

@ewels
Copy link

@ewels ewels commented May 11, 2017

Hi @gkovacs,

Many thanks for your work on this package, it's a great help to have it work for all versions of Python and available on PyPI.

I ran into a strange bug yesterday where I was getting the following ImportError when including the module:

Traceback (most recent call last):
  File "test_simple.py", line 3, in <module>
    import lzstring
  File "/Users/philewels/GitHub/lz-string-python/lzstring/__init__.py", line 8, in <module>
    from builtins import range
ImportError: No module named builtins

After scratching my head for a while, I figured out that it was because I had an old version of the future module installed (v0.13.1). Upgrading to v0.14.0 or above seems to solve this import error.

To prevent other people running into this problem, I've updated setup.py so that the installation requires at least v0.14.0 of the future module.

I've also added a .travis.yml file to enable continuous integration for multiple versions of Python. For an example, see https://travis-ci.org/ewels/lz-string-python (happy to remove this from the PR if you'd rather not have it).

Phil

@gkovacs gkovacs merged commit 6840ae5 into gkovacs:master May 18, 2017
@ewels
Copy link
Author

ewels commented May 19, 2017

Great stuff, thanks @gkovacs! I hope it's ok, but I took the liberty of packaging this up for conda in the conda-forge channel. The PR is currently open here: conda-forge/staged-recipes#2988

Would you like me to add / set you as the maintainer for the conda package?

@gkovacs
Copy link
Owner

gkovacs commented May 19, 2017

@ewels You can set yourself as the maintainer, I don't know much about conda packaging

@jakirkham
Copy link

Great stuff.

Would either of you mind adding a MANIFEST.in with the line include LICENSE.md? That should make sure it shows up in future releases to PyPI.

@ewels
Copy link
Author

ewels commented May 19, 2017

Done in #3 👍

@ewels
Copy link
Author

ewels commented May 19, 2017

Also, if you want the automated testing @gkovacs then you'll need to enable Travis here: https://travis-ci.org/gkovacs/lz-string-python (then you'll get e-mails telling you if any changes in commits / PRs break the tests on any versions of Python).

@jakirkham
Copy link

Thanks @ewels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants