-
Notifications
You must be signed in to change notification settings - Fork 37
Skip CLI version in aw-info.json for development and test builds #6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <[email protected]>
Contributor
|
@copilot filter out version if "dirty" is present too |
Co-authored-by: pelikhan <[email protected]>
Contributor
|
@copilot merge main |
Contributor
|
@copilot also do not emit "test" version |
Co-authored-by: pelikhan <[email protected]>
Copilot
AI
changed the title
[WIP] Update compiler to emit CLI version info for released builds
Skip CLI version in aw-info.json for development builds
Dec 19, 2025
Co-authored-by: pelikhan <[email protected]>
Contributor
Author
Copilot
AI
changed the title
Skip CLI version in aw-info.json for development builds
Skip CLI version in aw-info.json for development and test builds
Dec 19, 2025
mnkiefer
pushed a commit
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler was emitting CLI version information in
aw-info.jsonfor all builds, including development and test builds where the version is meaningless (e.g., "dev", commit hashes with "dirty", or "test" versions).Changes
Modified
generateCreateAwInfoinpkg/workflow/compiler_yaml.go:isReleasedVersion()helper function to centralize version filtering logiccli_versionfield for released buildsUpdated test coverage:
cli_versionis excluded for dev, dirty, and test buildsTestBothVersionsInAwInfoto use valid version stringExamples
Development build (version="dev"):
Dirty build (version="708d3ee-dirty"):
Test build (version="1.0.0-test"):
Released build (version="1.2.3"):
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.