Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the installation strategy for the spark-template development environment by modularizing the tool installation process and improving the coordination between different installation scripts.
- Separates the download/preparation phase from the installation phase across multiple scripts
- Introduces modular installation with specific component targets (services, sdk, cli)
- Replaces temporary directory generation with a fixed
/tmp/sparklocation for better predictability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.devcontainer/refreshTools.sh |
Simplified to only handle download and preparation, returning release ID for coordination |
.devcontainer/postStartCommand.sh |
Enhanced to orchestrate modular installations of services, sdk, and cli components |
.devcontainer/onCreate.sh |
Updated to use the new coordinated installation approach |
Comment on lines
+10
to
+11
| TEMP_DIR=/tmp/spark | ||
| rm -rf $TEMP_DIR |
There was a problem hiding this comment.
Using a fixed temporary directory path without proper cleanup could lead to race conditions or security issues if multiple instances run concurrently. Consider using a unique subdirectory or ensuring proper isolation.
Suggested change
| TEMP_DIR=/tmp/spark | |
| rm -rf $TEMP_DIR | |
| TEMP_DIR="/tmp/spark-$$" | |
| trap "rm -rf $TEMP_DIR" EXIT |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eljog
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.