Skip to content

Conversation

@Zenuka
Copy link
Contributor

@Zenuka Zenuka commented Feb 10, 2016

Added bower_components to .gitignore to not include bower packages: http://bower.io/

Added bower_components to .gitignore
@Zenuka Zenuka changed the title Update VisualStudio.gitignore Add bower_components to VisualStudio.gitignore Feb 10, 2016
@shiftkey
Copy link
Member

This was removed in #1529 and I'd love @sayedihashimi to chime in here about why he proposed that

@shiftkey
Copy link
Member

Oh, and @barrytang

@sayedihashimi
Copy link
Contributor

I just made the commit the decision was made by @DamianEdwards and @madskristensen, they should reply with more info.

@Zenuka
Copy link
Contributor Author

Zenuka commented Feb 11, 2016

Ah, didn't search enough, my bad... Maybe we could add it commented out?

@shiftkey
Copy link
Member

@Zenuka I'd like that

@Zenuka
Copy link
Contributor Author

Zenuka commented Feb 12, 2016

@shiftkey, done

@shiftkey
Copy link
Member

I'm letting this sit until Friday 19 February AEDST for feedback.

@haacked
Copy link
Contributor

haacked commented Feb 23, 2016

👍 to merging this.

@shiftkey
Copy link
Member

Oops, missed my self-imposed deadline. Let's take this in and see what other feedback comes up.

shiftkey added a commit that referenced this pull request Feb 24, 2016
Add bower_components to VisualStudio.gitignore
@shiftkey shiftkey merged commit 9f8e411 into github:master Feb 24, 2016
@Zenuka Zenuka deleted the bower_components branch February 24, 2016 15:38
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Add bower_components to VisualStudio.gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants