Skip to content

[ca] fix: update test expectations for actions/download-artifact v8.0.1#20566

Merged
pelikhan merged 2 commits intomainfrom
ci-fix/update-action-pins-v8-0-1-6cc59574653059c5
Mar 11, 2026
Merged

[ca] fix: update test expectations for actions/download-artifact v8.0.1#20566
pelikhan merged 2 commits intomainfrom
ci-fix/update-action-pins-v8-0-1-6cc59574653059c5

Conversation

@github-actions
Copy link
Contributor

Summary

CI was failing (run #22967379194) due to test expectations that weren't updated when action_pins.json was updated to use actions/download-artifact@v8.0.1.

Failures Found

4 tests were failing in pkg/workflow:

  • TestGetActionPinsSorting — expected 39 action pins but JSON has 31
  • TestOutputPullRequestJobGeneration — expected old v8.0.0 SHA (70fc10c6)
  • TestBuildAgentOutputDownloadSteps — expected old v8.0.0 SHA (70fc10c6)
  • TestWasmGolden_CompileFixtures (3 subtests) — golden files had old v8.0.0 SHA

Fixes Applied

  1. pkg/workflow/action_pins_test.go — Updated expected pin count from 39 → 31
  2. pkg/workflow/safe_output_helpers_test.go — Updated expected SHA from 70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3 (v8.0.0) → 3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c (v8.0.1)
  3. pkg/workflow/compile_outputs_pr_test.go — Same SHA update
  4. 3 golden files in testdata/wasm_golden/ — Same SHA update
  5. pkg/cli/workflows/example-blocked-domains.lock.yml — Recompiled to pick up v8.0.1 pin

Validation

  • make fmt — code formatted
  • make lint — all linters pass
  • go test ./... -short — all tests pass (including all 4 previously failing tests)
  • make recompile — 166/166 workflows compiled successfully

Generated by CI Cleaner ·

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

  • expires on Mar 13, 2026, 6:41 PM UTC

Update test assertions and golden files to reflect new action pin
for actions/download-artifact@v8.0.1 (3e5f45b2) replacing v8.0.0
(70fc10c6). Also fix pin count assertion from 39 to 31.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review March 11, 2026 19:25
Copilot AI review requested due to automatic review settings March 11, 2026 19:25
@pelikhan pelikhan merged commit c0ec218 into main Mar 11, 2026
45 of 47 checks passed
@pelikhan pelikhan deleted the ci-fix/update-action-pins-v8-0-1-6cc59574653059c5 branch March 11, 2026 19:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates workflow-related test fixtures/expectations to match the actions/download-artifact pin bump to v8.0.1 (and associated regenerated compiled outputs), resolving CI failures caused by stale SHAs and counts.

Changes:

  • Updated workflow unit tests to expect the new actions/download-artifact@v8.0.1 pinned SHA and the current action pin count.
  • Regenerated wasm golden fixtures to reflect the updated pinned SHA.
  • Recompiled example-blocked-domains.lock.yml, updating the embedded action pin and other generated workflow details.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/workflow/action_pins_test.go Adjusts expected action pin count (39 → 31).
pkg/workflow/safe_output_helpers_test.go Updates expected download-artifact pinned SHA in generated step assertions.
pkg/workflow/compile_outputs_pr_test.go Updates expected download-artifact pinned SHA in compiled PR job generation test.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden Refreshes golden output to include v8.0.1 pinned SHA.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden Refreshes golden output to include v8.0.1 pinned SHA.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden Refreshes golden output to include v8.0.1 pinned SHA.
pkg/cli/workflows/example-blocked-domains.lock.yml Regenerated compiled example workflow, including updated download-artifact pin and additional generated workflow updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

#
#
# gh-aw-metadata: {"schema_version":"v1","frontmatter_hash":"80100e1eccadf076c6f02412860f8dfb229e60d1753790630cb4589468eee780"}
# gh-aw-metadata: {"schema_version":"v2","frontmatter_hash":"80100e1eccadf076c6f02412860f8dfb229e60d1753790630cb4589468eee780","strict":true}
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description frames this as updating test expectations for the download-artifact v8.0.1 pin, but this lockfile recompile also introduces additional behavior/version changes (e.g., schema_version v2 + strict mode metadata, switching Copilot CLI install/agent version to "latest", updated MCP image tags, step-summary handling, and artifact naming). Please either (a) confirm these extra changes are intended for this PR and update the PR summary accordingly, or (b) regenerate the lockfile in a way that only reflects the download-artifact pin change / split the extra lockfile changes into a separate PR for easier review.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants