[ca] fix: update test expectations for actions/download-artifact v8.0.1#20566
[ca] fix: update test expectations for actions/download-artifact v8.0.1#20566
Conversation
Update test assertions and golden files to reflect new action pin for actions/download-artifact@v8.0.1 (3e5f45b2) replacing v8.0.0 (70fc10c6). Also fix pin count assertion from 39 to 31. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates workflow-related test fixtures/expectations to match the actions/download-artifact pin bump to v8.0.1 (and associated regenerated compiled outputs), resolving CI failures caused by stale SHAs and counts.
Changes:
- Updated workflow unit tests to expect the new
actions/download-artifact@v8.0.1pinned SHA and the current action pin count. - Regenerated wasm golden fixtures to reflect the updated pinned SHA.
- Recompiled
example-blocked-domains.lock.yml, updating the embedded action pin and other generated workflow details.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/action_pins_test.go | Adjusts expected action pin count (39 → 31). |
| pkg/workflow/safe_output_helpers_test.go | Updates expected download-artifact pinned SHA in generated step assertions. |
| pkg/workflow/compile_outputs_pr_test.go | Updates expected download-artifact pinned SHA in compiled PR job generation test. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden | Refreshes golden output to include v8.0.1 pinned SHA. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden | Refreshes golden output to include v8.0.1 pinned SHA. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden | Refreshes golden output to include v8.0.1 pinned SHA. |
| pkg/cli/workflows/example-blocked-domains.lock.yml | Regenerated compiled example workflow, including updated download-artifact pin and additional generated workflow updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # | ||
| # | ||
| # gh-aw-metadata: {"schema_version":"v1","frontmatter_hash":"80100e1eccadf076c6f02412860f8dfb229e60d1753790630cb4589468eee780"} | ||
| # gh-aw-metadata: {"schema_version":"v2","frontmatter_hash":"80100e1eccadf076c6f02412860f8dfb229e60d1753790630cb4589468eee780","strict":true} |
There was a problem hiding this comment.
The PR title/description frames this as updating test expectations for the download-artifact v8.0.1 pin, but this lockfile recompile also introduces additional behavior/version changes (e.g., schema_version v2 + strict mode metadata, switching Copilot CLI install/agent version to "latest", updated MCP image tags, step-summary handling, and artifact naming). Please either (a) confirm these extra changes are intended for this PR and update the PR summary accordingly, or (b) regenerate the lockfile in a way that only reflects the download-artifact pin change / split the extra lockfile changes into a separate PR for easier review.
Summary
CI was failing (run #22967379194) due to test expectations that weren't updated when
action_pins.jsonwas updated to useactions/download-artifact@v8.0.1.Failures Found
4 tests were failing in
pkg/workflow:TestGetActionPinsSorting— expected 39 action pins but JSON has 31TestOutputPullRequestJobGeneration— expected oldv8.0.0SHA (70fc10c6)TestBuildAgentOutputDownloadSteps— expected oldv8.0.0SHA (70fc10c6)TestWasmGolden_CompileFixtures(3 subtests) — golden files had oldv8.0.0SHAFixes Applied
pkg/workflow/action_pins_test.go— Updated expected pin count from 39 → 31pkg/workflow/safe_output_helpers_test.go— Updated expected SHA from70fc10c6e5e1ce46ad2ea6f2b72d43f7d47b13c3(v8.0.0) →3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c(v8.0.1)pkg/workflow/compile_outputs_pr_test.go— Same SHA updatetestdata/wasm_golden/— Same SHA updatepkg/cli/workflows/example-blocked-domains.lock.yml— Recompiled to pick up v8.0.1 pinValidation
make fmt— code formattedmake lint— all linters passgo test ./... -short— all tests pass (including all 4 previously failing tests)make recompile— 166/166 workflows compiled successfullyWarning
The following domain was blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.