Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like github/auto-complete-element#104 and github/auto-check-element#62, this PR upgrades us to the latest idioms we have within the Custom Elements landscape at GitHub. This means:
Develop development changes:
Uses web-test-runner over karma.
Uses a slightly improved eslint config
Minor changes to TSconfig
Uses esbuild over rollup
User faces changes:
Emits JSX types, making it compatible with React
Reworks exports allowing for various patterns, including importing the web component without defining, or defining under different scopes or registries.
Outputs a custom elements manifest.
These changes make it easier for us to integrate into various systems, without causing breakages in older systems.
Closes #21, #20, #19, #17, #14, #13, #12