Update updating-credentials-from-the-macos-keychain.md#7957
Closed
Bishwa05 wants to merge 3 commits intogithub:mainfrom
Closed
Update updating-credentials-from-the-macos-keychain.md#7957Bishwa05 wants to merge 3 commits intogithub:mainfrom
Bishwa05 wants to merge 3 commits intogithub:mainfrom
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@Bishwa05 Thank you for opening this PR 👍 I will triage this for review ⚡ |
Member
|
Thanks @Bishwa05! Both of these additions are technically accurate, but not strictly necessary for readers to accomplish their goals. Since every added word makes an article more work to read and therefore less accessible, we want to avoid adding unnecessary extra words. I'm going to close this now but I hope I've explained clearly why I'm doing so! ✨ Thanks again for spending time on this and contributing to our documentation. |
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
This was referenced Aug 1, 2022
This was referenced Aug 1, 2022
This was referenced Aug 1, 2022
This was referenced Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
This page of document does not says we have to update the password with the generated token in key chain.
The PR is created to provide more clarity for mac users.
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):