Elaborate on how to escape multiple labels in issue templates#519
Merged
felicitymay merged 4 commits intogithub:mainfrom Oct 21, 2020
MortenBoysen:patch-1
Merged
Elaborate on how to escape multiple labels in issue templates#519felicitymay merged 4 commits intogithub:mainfrom MortenBoysen:patch-1
felicitymay merged 4 commits intogithub:mainfrom
MortenBoysen:patch-1
Conversation
Escaping them individually led to bugs in our templates that I had to spend time on tracking down.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
Thanks so much for opening a PR @MortenBoysen! I'll get this triaged for review ⚡ |
felicitymay
reviewed
Oct 17, 2020
Contributor
felicitymay
left a comment
There was a problem hiding this comment.
Sorry to hear that this cost you time debugging your template but many thanks for submitting a fix to stop it affecting others 💖
...building-a-strong-community/manually-creating-a-single-issue-template-for-your-repository.md
Outdated
Show resolved
Hide resolved
Contributor
|
👋🏻 Hi @MortenBoysen - before I merge this PR, I'd really like to know your thoughts on my suggested change to introductory text. Would that have been any clearer? |
…-single-issue-template-for-your-repository.md Co-authored-by: Felicity Chapman <[email protected]>
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Escaping them individually led to bugs in our templates that I had to spend time on tracking down.
What's being changed:
The description on how to change labels in issue templates
Check off the following: