Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
left a comment
There was a problem hiding this comment.
Thanks for catching these @Simran-B! I added one suggestion. Once you accept that suggestion, we can review it again and get this merged in ⚡
Co-authored-by: Janice <janiceilene@github.com>
|
You're welcome @janiceilene. Applied your suggestion. Can be merged, but you may want to address the remaining dead anchor links in another PR one way or the other. |
|
@Simran-B Thanks for pointing those out! We did some last minute restructuring of this doc and must have missed the table of contents 😅 Would you open an issue about the broken links you found? Maybe someone else will get to fixing them before I do 🤞 I'll merge this in as soon as the branch is updated and all of the tests are green 💚 |
|
If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
|
@all-contributors please add Simran-B for doc |
|
I've put up a pull request to add @Simran! 🎉 |
|
Sorry, wrong user 😞 @all-contributors please add @Simran-B for doc |
|
I've put up a pull request to add @Simran-B! 🎉 |
* remove leading slashes in links * Use full URL * Remove leading slash * remove unused links from FAQs * Fix URL to advanced analytic queries * remove variable from full URL * Remove leading slash * Remove unused links * Remove leading slashes * Remove trailing slash * Fix path * Fix URL * Update external link * Update external URL * fix path * fix path * Remove trailing slash * remove trailing slash * remove trailing slash * Remove trailing slashes * Apply suggestions from code review Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan Booz <ryan@timescale.com> * Apply suggestions from code review Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
Why:
Some of the links in CONTRIBUTING.md are broken.
What's being changed:
Fix two typos and change anchor link to forking section, which does not have dedicated headlines for GitHub Desktop and command-line.
There are a couple more dead anchor links, but it looks like the content does not exist yet?
Check off the following:
All of the tests are passing.I have reviewed my changes in staging.