Skip to content

Comments

Improve description of branch targeting for action release management#2326

Merged
megbird merged 2 commits intogithub:mainfrom
martindes01:fix-2290
Jan 7, 2021
Merged

Improve description of branch targeting for action release management#2326
megbird merged 2 commits intogithub:mainfrom
martindes01:fix-2290

Conversation

@martindes01
Copy link
Contributor

@martindes01 martindes01 commented Dec 24, 2020 •
edited
Loading

Why:

What's being changed:

  • Clarify use of target branch
  • Separate clauses for ease of reading
  • Remove unnecessary conjunction
  • Replace pronoun to eliminate ambiguity

Check off the following:

@welcome
Copy link

welcome bot commented Dec 24, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 28, 2020
@janiceilene
Copy link
Contributor

janiceilene commented Dec 28, 2020

@martindes01 Thanks so much for opening a PR! I'll get this triaged for review ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 4, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@janiceilene
Copy link
Contributor

janiceilene commented Jan 5, 2021

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

megbird
megbird approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great rewording ⚡ thank you for clearing this up for our users!

@megbird megbird merged commit 855275a into github:main Jan 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@martindes01 martindes01 deleted the fix-2290 branch January 8, 2021 17:57
@snyk-bot snyk-bot mentioned this pull request Jan 6, 2023
Open
This was referenced Feb 3, 2023
Open
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Nov 25, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Nov 27, 2023
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Nov 28, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Nov 28, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@megbird megbird megbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in Finding and customizing actions

3 participants

@martindes01 @janiceilene @megbird