Skip to content

Add Dart to dependency scope table#22019

Merged
mchammer01 merged 4 commits intogithub:mainfrom
AAugustine:AAugustine-add-dart
Nov 17, 2022
Merged

Add Dart to dependency scope table#22019
mchammer01 merged 4 commits intogithub:mainfrom
AAugustine:AAugustine-add-dart

Conversation

@AAugustine
Copy link
Contributor

@AAugustine AAugustine commented Nov 14, 2022 •
edited
Loading

Why:

Closes https://github.com/github/docs-content/issues/8691
Closes https://github.com/github/dependabot-alerts/issues/851

What's being changed (if available, include any code snippets, screenshots, or gifs):

Table located at: data/reusables/dependabot/dependabot-alerts-dependency-scope.md is being changed to include Dart

Screen Shot 2022-11-14 at 4 45 05 PM

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 14, 2022
@cmwilson21
Copy link
Contributor

cmwilson21 commented Nov 15, 2022

👋 @AAugustine Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review dependabot Content related to Dependabot and removed triage Do not begin working on this issue until triaged by the team labels Nov 15, 2022
@mchammer01 mchammer01 self-requested a review November 17, 2022 08:50
mchammer01
mchammer01 previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AAugustine 👋🏻 - this LGTM ✨
Inquired with you privately about versioning. Happy to merge this once we've established that there are no versioning considerations that we need to add 😃

mchammer01
mchammer01 reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the relevant versioning to the two new rows.
Will test this on staging before merging.

mchammer01
mchammer01 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💖
Thanks for double-checking the versioning for me 🙇🏻

@mchammer01 mchammer01 enabled auto-merge November 17, 2022 15:05
@mchammer01 mchammer01 merged commit 69f441b into github:main Nov 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@AAugustine AAugustine deleted the AAugustine-add-dart branch November 17, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AAugustine @cmwilson21 @mchammer01