Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
maharshi-sinha
left a comment
There was a problem hiding this comment.
Looks good but you can also add (commands) in brackets too!
AnilSeervi
left a comment
There was a problem hiding this comment.
I don't think these must to change to ⌘ from Command.
The guidelines specifically instructs to use full words instead of symbols
My mistake! thanks for correcting me 👍 |
|
@Zearin Thanks for opening this PR! ✨ We appreciate the thought you put into this, but as @AnilSeervi pointed out in our guidelines, our practice is to use the full word "Command". If you see instances where that is not the case, feel free to open a PR for that fix! I'm going to go ahead and close this PR. Thank you for interest and passion for improving the docs! 💛 |
What's being changed (if available, include any code snippets, screenshots, or gifs):
Some Mac shortcuts used Command while others used ⌘
The symbol is well-known, shorter, and (to my eyes at least) “parses” easier than the reading the word “Command”.
So, might as well be consistent with it.
Writer impact (This section is for GitHub staff members only):