Merged
Conversation
Contributor
|
Aha I just noticed the same thing #186 🤦 will close mine |
Co-authored-by: Tom Jenkinson <tjenkinson@users.noreply.github.com>
Contributor
Author
|
Those failing tests are expected! https://github.com/github/docs/pull/180/checks?check_run_id=1222424377#step:9:47 I will commit a fix to update the allow list soon. cc @rachmari |
JasonEtco
reviewed
Oct 8, 2020
Contributor
JasonEtco
left a comment
JasonEtco
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix @zeke (and @tjenkinson)! ✨
JasonEtco
approved these changes
Oct 8, 2020
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
…ub#180) * Cleaned up left nav entries and tutorials pages for consistency * Cleaned up left nav entries and tutorials pages for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier today we got a pull request to automerge dependabot PRs: #177 (Thanks @tjenkinson ✨ )
This PR introduced a new Actions workflow that uses a GitHub Action tjenkinson/gh-action-auto-merge-dependency-updates that we are not already using in the codebase. I recently added an automated test to catch these scenarios, but my test didn't catch this new Action.
This PR updates the logic in that test to make sure that:
cc @github/docs-engineering