fix: Links to localhost addresses#1505
Merged
lucascosti merged 3 commits intogithub:mainfrom Dec 15, 2020
Merged
Conversation
nschonni
commented
Nov 20, 2020
Contributor
|
@nschonni Thanks so much for opening a PR! I'll get this triaged for review ✨ |
janiceilene
added
content
Contributor
|
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
github-actions
bot
added
the
stale
Put them in code blocks and stop ignoring them from link checking
nschonni
force-pushed
the
localhost-links
branch
from
5bc2c93 to
6d721e1
Compare
janiceilene
removed
the
stale
Contributor
|
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
github-actions
bot
added
the
stale
janiceilene
removed
the
stale
lucascosti
approved these changes
Dec 15, 2020
Contributor
lucascosti
left a comment
lucascosti
left a comment
There was a problem hiding this comment.
Looks great, @nschonni, thanks for this change! I'll just commit the one suggestion and then merge this in 🚀
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced Jun 19, 2022
This was referenced Sep 30, 2022
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
Add link to the chunk time blog post, which is a good extended discussion of how to optimize time partitions. Co-authored-by: Lana Brindley <github@lanabrindley.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Rather than ignoring localhost links in the linter, it's better to just not directly link to them
What's being changed:
Change localhost links to code blocks
Check off the following: