Suggest to avoid "Master branch" instead of "Default branch"#1496
Merged
emilyistoofunky merged 2 commits intogithub:mainfrom Nov 23, 2020
Merged
Suggest to avoid "Master branch" instead of "Default branch"#1496emilyistoofunky merged 2 commits intogithub:mainfrom
emilyistoofunky merged 2 commits intogithub:mainfrom
Conversation
Contributor
|
@ba32107 Thanks so much for opening a PR! I'll get this triaged for review ✨ |
emilyistoofunky
approved these changes
Nov 23, 2020
Member
emilyistoofunky
left a comment
emilyistoofunky
left a comment
There was a problem hiding this comment.
Thanks for letting us know about this @ba32107! ⚡ I'll get this merged.
| | Allowlist | Whitelist | | ||
| | Denylist | Blacklist | | ||
| | Main branch | Default branch | | ||
| | Default/Main branch | Master branch | |
Member
There was a problem hiding this comment.
It looks like we made a typo here - thanks for catching it!
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
This was referenced Aug 1, 2022
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
The Timescale Cloud excerpt was defined twice, and the less-descriptive definition was being used. Remove the duplicate definition and refine the remaining one to better promote the benefits of Cloud
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Fixes #1495
What's being changed:
I've changed the suggestion to avoid "Default branch" to avoid "Master branch". I believe the latter can be considered offending, whereas I don't see any issue with the term "Default branch".
Check off the following: