Skip to content

Update ignoring-files.md#11090

Merged
ramyaparimi merged 7 commits intogithub:mainfrom
bphermansson:patch-2
Oct 18, 2021
Merged

Update ignoring-files.md#11090
ramyaparimi merged 7 commits intogithub:mainfrom
bphermansson:patch-2

Conversation

@bphermansson
Copy link
Contributor

@bphermansson bphermansson commented Oct 11, 2021

Clarified that a successful "touch .gitignore" gives no output.

Why:

Closes #11077

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Clarified that a successful "touch .gitignore" gives no output.
@welcome
Copy link

welcome bot commented Oct 11, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review labels Oct 12, 2021
@ramyaparimi
Copy link
Contributor

@bphermansson
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bphermansson! I'm going to apply a small change and then mark this as ready to merge. The repo is currently frozen, but we'll merge as soon as we can after that's over.

@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Oct 15, 2021
@ramyaparimi ramyaparimi enabled auto-merge October 18, 2021 15:17
@ramyaparimi ramyaparimi merged commit 9c8b655 into github:main Oct 18, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify content on ignoring files

4 participants