Python: Autoformat everything using qlformat.#3915
Merged
RasmusWL merged 3 commits intogithub:masterfrom Jul 7, 2020
Merged
Conversation
Will need subsequent PRs fixing up test failures (due to deprecated methods moving around), but other than that everything should be straight-forward.
RasmusWL
previously approved these changes
Jul 7, 2020
Member
RasmusWL
left a comment
There was a problem hiding this comment.
Looked over all non whitespace-only changes, and it looks good 👍
Comment on lines
-9
to
-26
|
|
||
| // /** | ||
| // * Holds if taint propagates from `source` to `sink` in zero or more local | ||
| // * (intra-procedural) steps. | ||
| // */ | ||
| // predicate localTaint(DataFlow::Node source, DataFlow::Node sink) { localTaintStep*(source, sink) } | ||
|
|
||
| // // /** | ||
| // // * Holds if taint can flow from `e1` to `e2` in zero or more | ||
| // // * local (intra-procedural) steps. | ||
| // // */ | ||
| // // predicate localExprTaint(Expr e1, Expr e2) { | ||
| // // localTaint(DataFlow::exprNode(e1), DataFlow::exprNode(e2)) | ||
| // // } | ||
|
|
||
| // // /** A member (property or field) that is tainted if its containing object is tainted. */ | ||
| // // abstract class TaintedMember extends AssignableMember { } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Oh, huh. I guess those empty lines really ought to have had empty comments as well.
RasmusWL
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3443 revived. (There were too many merge errors to deal with otherwise.)
Will need subsequent PRs fixing up test failures (due to deprecated
methods moving around), but other than that everything should be
straight-forward.