JS: Parse arbitary module specifiers #17166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
arbitarySpecifiers
branch
from
13ef69a to
b8187ed
Compare
sidshank
approved these changes
Aug 7, 2024
Contributor
sidshank
left a comment
sidshank
left a comment
There was a problem hiding this comment.
Parser changes look good!
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#2154.
It's been a feature since ES2022, but we haven't had support for it yet.
But now TS 5.6 is about to add the feature, so we should probably support it.
Evaluation was uneventful. We parse some new files in babel and test262 that we didn't parse before, and nothing broke.