feat: propose CODEOWNERS file when missing #325
+156
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances the cleanowners GitHub Action to create placeholder CODEOWNERS files for repositories that are missing them or have empty ones, rather than simply skipping those repositories.
Changes:
- Adds functionality to generate and propose placeholder CODEOWNERS files via pull requests for repositories without valid CODEOWNERS files
- Updates all user-facing messages and statistics to reflect "missing or empty CODEOWNERS files" instead of just "missing"
- Refactors the get_codeowners_file function to use a more concise loop structure
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cleanowners.py | Implements placeholder CODEOWNERS generation, adds create_new parameter to commit_changes, refactors get_codeowners_file, and updates statistics messages |
| test_cleanowners.py | Adds comprehensive tests for new build_default_codeowners function, tests for create_new parameter, and updates empty file handling test expectations |
| markdown_writer.py | Updates markdown report messages to reflect "missing or empty" terminology |
| test_markdown_writer.py | Updates test expectations to match new "missing or empty" terminology |
| README.md | Documents the new behavior of creating placeholder CODEOWNERS files |
vchrombie
changed the title
vchrombie
changed the title
Add placeholder CODEOWNERS content for repos without one, and open a PR instead of skipping. Signed-off-by: Venu Vardhan Reddy Tekula <venuvrtekula@gmail.com>
vchrombie
force-pushed
the
feat/suggest-codeowners-pr-23
branch
from
b11665c to
0748f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Add placeholder CODEOWNERS content for repos without one, and open a PR instead of skipping.
Tested this on a test repository
https://github.com/vchrombie/cleanowners-test/actions/runs/21336076769/job/61408165828
vchrombie/cleanowners-test#1
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking