Skip to content

Conversation

@keithamus
Copy link
Contributor

When working on this code I realised we're using a WeakMap to store references to controllers that own shadowRoots, however we can use .host to get the owner of a ShadowRoot, avoiding the need for a WeakMap.

@keithamus keithamus requested review from a team and koddsson October 10, 2022 15:07
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus merged commit 09a63b3 into v2 Oct 10, 2022
@keithamus keithamus deleted the use-shadowroot-host-instead-of-weakmap branch October 10, 2022 15:47
@keithamus keithamus mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants