Skip to content

ref(inbound-filters): Move desc and label to frontend + add link to health check doc#54846

Merged
priscilawebdev merged 1 commit intomasterfrom
priscila/ref/inbound-filters/translate-filter-strings-in-frontend-and-add-health-check-link
Aug 17, 2023
Merged

ref(inbound-filters): Move desc and label to frontend + add link to health check doc#54846
priscilawebdev merged 1 commit intomasterfrom
priscila/ref/inbound-filters/translate-filter-strings-in-frontend-and-add-health-check-link

Conversation

@priscilawebdev
Copy link
Member

closes: #54539

Requires: getsentry/sentry-docs#7649

Preview:

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 16, 2023
@priscilawebdev priscilawebdev requested review from a team, RaduW and ale-cota August 16, 2023 15:35
Copy link
Contributor

@RaduW RaduW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing some of the filters (maybe the custom filters) ?
On server side we emit up to 12 filters.

Here's a list:

    IP_ADDRESS = "ip-address"
    RELEASE_VERSION = "release-version"
    ERROR_MESSAGE = "error-message"
    BROWSER_EXTENSION = "browser-extensions"
    LEGACY_BROWSER = "legacy-browsers"
    LOCALHOST = "localhost"
    WEB_CRAWLER = "web-crawlers"
    INVALID_CSP = "invalid-csp"
    CORS = "cors"
    DISCARDED_HASH = "discarded-hash"  # Not replicated in Relay
    CRASH_REPORT_LIMIT = "crash-report-limit"  # Not replicated in Relay
    HEALTH_CHECK = "filtered-transaction"  # Ignore health-check transactions

Could we please confirm that we handle all inbound filter properly (common filters or custom filters) ?

RaduW
RaduW previously requested changes Aug 17, 2023
Copy link
Contributor

@RaduW RaduW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing some of the filters (maybe the custom filters) ?
On server side we emit up to 12 filters.

Here's a list:

    IP_ADDRESS = "ip-address"
    RELEASE_VERSION = "release-version"
    ERROR_MESSAGE = "error-message"
    BROWSER_EXTENSION = "browser-extensions"
    LEGACY_BROWSER = "legacy-browsers"
    LOCALHOST = "localhost"
    WEB_CRAWLER = "web-crawlers"
    INVALID_CSP = "invalid-csp"
    CORS = "cors"
    DISCARDED_HASH = "discarded-hash"  # Not replicated in Relay
    CRASH_REPORT_LIMIT = "crash-report-limit"  # Not replicated in Relay
    HEALTH_CHECK = "filtered-transaction"  # Ignore health-check transactions

Could we please confirm that we handle all inbound filter properly (common filters or custom filters) ?

@priscilawebdev
Copy link
Member Author

@RaduW the other filters come from the project settings and not from the /filters/ endpoint. Example:

"options": {
"sentry:token": "59e1c2e83ac611eeb4ed7213a7859fc7",
"quotas:spike-protection-disabled": false,
"sentry:option-epoch": 11,
"sentry:csp_ignored_sources_defaults": true,
"sentry:csp_ignored_sources": "",
"sentry:reprocessing_active": false,
"filters:blacklisted_ips": "",
"filters:react-hydration-errors": true,
"filters:releases": "",
"filters:error_messages": "",
"feedback:branding": true
},

perhaps we should unify them one day but until then 🤷‍♀️

@priscilawebdev priscilawebdev enabled auto-merge (squash) August 17, 2023 09:47
@priscilawebdev priscilawebdev dismissed RaduW’s stale review August 17, 2023 09:47

explained that other filters are coming from elsewhere

@priscilawebdev priscilawebdev merged commit 51fc38f into master Aug 17, 2023
@priscilawebdev priscilawebdev deleted the priscila/ref/inbound-filters/translate-filter-strings-in-frontend-and-add-health-check-link branch August 17, 2023 09:47
@RaduW RaduW self-requested a review August 17, 2023 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs & link for health check inbound filter

3 participants