Make use of SPANDATA consistent in AI integrations.`#4376
Merged
antonpirker merged 1 commit intopotel-basefrom May 9, 2025
Merged
Make use of SPANDATA consistent in AI integrations.`#4376antonpirker merged 1 commit intopotel-basefrom
SPANDATA consistent in AI integrations.`#4376antonpirker merged 1 commit intopotel-basefrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4376 +/- ##
===========================================
Coverage 84.37% 84.37%
===========================================
Files 144 144
Lines 14691 14697 +6
Branches 2339 2339
===========================================
+ Hits 12395 12401 +6
Misses 1567 1567
Partials 729 729
|
sentrivana
approved these changes
May 9, 2025
szokeasaurusrex
approved these changes
May 9, 2025
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
I did notice that there are fewer files changed here than in #4373 – I'm assuming these files don't exist in POTel?
Contributor
Author
|
the other changes have already been made in the other PR. this one just adds the new occurences of not using SPANDATA that have been introduced in potel. |
Member
|
ah got it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not using plain strings, but always use
SPANDATA. Follow up to this PR: #4373