Dramatiq integration from @jacobsvante#3397
Merged
antonpirker merged 22 commits intomasterfrom Aug 8, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3397 +/- ##
=======================================
Coverage 79.78% 79.79%
=======================================
Files 133 134 +1
Lines 14418 14503 +85
Branches 3036 3052 +16
=======================================
+ Hits 11504 11573 +69
- Misses 2083 2091 +8
- Partials 831 839 +8
|
…thon into antonpirker/dramatiq
Contributor
Author
|
Tested with this example project: |
Contributor
Author
|
Errors with stack traces and local vars are there: |
Contributor
Author
|
Additional dramatiq information is in the |
sentrivana
approved these changes
Aug 7, 2024
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
See some small comments. Overall LGTM. Thanks for porting <3
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Contributor
|
Thank you so much for integrating it ❤️ |
sentrivana
added a commit
that referenced
this pull request
Aug 12, 2024
This is the code from [sentry-dramatiq](https://github.com/jacobsvante/sentry-dramatiq). As described in this GitHub issue (#3387) @jacobsvante, the original maintainer of this integration, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it. This PR adds the current version of the `DramatiqIntegration` to our repo. (The original integrations has been ported to the new SDK 2.x API) Fixes #3387 --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This was referenced Aug 23, 2024
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
This is the code from [sentry-dramatiq](https://github.com/jacobsvante/sentry-dramatiq). As described in this GitHub issue (getsentry#3387) @jacobsvante, the original maintainer of this integration, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it. This PR adds the current version of the `DramatiqIntegration` to our repo. (The original integrations has been ported to the new SDK 2.x API) Fixes getsentry#3387 --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the code of sentry-dramatiq.
As described in this GitHub issue (#3387) @jacobsvante, the original maintainer of this integations, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it.
This PR adds the current version of the
DramatiqIntegrationto our repo.Fixes #3387
Documentation PR: getsentry/sentry-docs#11015