Conversation
Contributor
size-limit report 📦
|
…dn/cdn' into cg/JS-1443/add-tracingreplayfeedbacklogsmetrics-bundle
Base automatically changed from
cg/JS-452/support-sentry-logging-in-the-js-loader-and-cdn/cdn
to
develop
January 14, 2026 13:57
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
approved these changes
Jan 15, 2026
Member
Lms24
left a comment
There was a problem hiding this comment.
nice!
One thing to follow up on: Before we adapt the loader we need to make sure to export "shim" integrations/APIs that can be used in the metrics/logs bundles, in all non-metrics/logs bundles. So that when users switch off logging/metrics in the UI, we don't break their apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18783
ref #16314
Note that metrics were bundled into the base config and will be moved into this bundle starting with v11 (ref #18583)