feat(metrics): [Trace Metrics 16] Only send user attributes if sendDefaultPii is true#4995
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- [Trace Metrics 16] Only send user attributes if sendDefaultPii is true ([#4995](https://github.com/getsentry/sentry-java/pull/4995))If none of the above apply, you can opt out of this check by adding |
106a66c to
6cdbfb7
Compare
c3c0f3b to
0116a6b
Compare
Performance metrics 🚀
|
| "sentry.release", new SentryLogEventAttributeValue(SentryAttributeType.STRING, release)); | ||
| } | ||
|
|
||
| if (Platform.isJvm()) { |
There was a problem hiding this comment.
Should this be guarded by sendDefaultPii as well?
There was a problem hiding this comment.
Wasn't able to find a sendDefaultPii check for server name in other places and there's a dedicated option (isAttachServerName) for this too. So this seems to align with what we do in other places.
|
|
||
| setUser(attributes); | ||
| if (scopes.getOptions().isSendDefaultPii()) { | ||
| setUser(attributes); |
There was a problem hiding this comment.
At least on Android [we always seem to at least set the installation id] when no user is manually set, (
Doesn't need to be addressed here, but maybe worth talking about (also affects logs).
There was a problem hiding this comment.
Created #5018 so we can track it separately and unblock this PR.
0116a6b to
56879b3
Compare
6cdbfb7 to
15ec6da
Compare
|
cursor review |

📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps