feat(envelope-item): Support span type by buenaflor · Pull Request #4935 · getsentry/sentry-java

buenaflor · 2025-11-25T12:22:55Z

📜 Description

Span First initiative - this PR is needed for Dart/Flutter right now but will be needed in general in the future when Java also implements span first

💡 Motivation and Context

See span protocol https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/

Needed for processing envelope items with type span.

Currently needed in Flutter's span first implementation as we rely on Java's InternalSentrySdk.captureEnvelope. Without this support the envelope item type is set to unknown when you use captureEnvelope and the span won't be ingested

💚 How did you test it?

Unit test and manually tested together with the Sentry Flutter SDK

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

github-actions · 2025-11-25T12:23:25Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8d42537

CHANGELOG.md

buenaflor · 2025-11-25T12:41:38Z

sentry/src/main/java/io/sentry/SentryItemType.java

  CheckIn("check_in"),
  Feedback("feedback"),
  Log("log"),
+  Span("span"),
  Unknown("__unknown__"); // DataCategory.Unknown

  private final String itemType;


valid concern but I am not sure if we need to handle this now since we cannot capture spans directly from the java sdk anyway

hm, I think it's still valid even for the hybrid SDKs because client reports are counted from the unsent envelop items? But anyway, it can be done in a follow up PR later

I'll double check this

github-actions · 2025-11-25T12:39:48Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	307.88 ms	342.40 ms	34.53 ms
Size	1.58 MiB	2.13 MiB	557.54 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`604a261`	380.65 ms	451.27 ms	70.62 ms
`a416a65`	295.53 ms	373.74 ms	78.21 ms
`889ecea`	367.58 ms	437.52 ms	69.94 ms
`a5ab36f`	320.47 ms	389.77 ms	69.30 ms
`27d7cf8`	397.90 ms	498.65 ms	100.75 ms
`ee747ae`	400.46 ms	423.61 ms	23.15 ms
`d217708`	375.27 ms	415.68 ms	40.41 ms
`fcec2f2`	357.47 ms	447.32 ms	89.85 ms
`23d6b12`	354.10 ms	408.38 ms	54.28 ms
`d5a29b6`	298.62 ms	391.78 ms	93.16 ms

App size

Revision	Plain	With Sentry	Diff
`604a261`	1.58 MiB	2.10 MiB	533.42 KiB
`a416a65`	1.58 MiB	2.12 MiB	555.26 KiB
`889ecea`	1.58 MiB	2.11 MiB	539.75 KiB
`a5ab36f`	1.58 MiB	2.12 MiB	555.26 KiB
`27d7cf8`	1.58 MiB	2.12 MiB	549.42 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`d217708`	1.58 MiB	2.10 MiB	532.97 KiB
`fcec2f2`	1.58 MiB	2.12 MiB	551.50 KiB
`23d6b12`	1.58 MiB	2.10 MiB	532.31 KiB
`d5a29b6`	1.58 MiB	2.12 MiB	549.37 KiB

Previous results on branch: feat/support-span-sentry-item-type

Startup times

Revision	Plain	With Sentry	Diff
`598bacc`	298.68 ms	352.42 ms	53.74 ms
`c357e8a`	408.90 ms	554.76 ms	145.86 ms
`a110e56`	297.40 ms	373.86 ms	76.45 ms
`d9d541c`	329.45 ms	357.49 ms	28.04 ms
`e9c7b57`	321.04 ms	392.09 ms	71.05 ms

App size

Revision	Plain	With Sentry	Diff
`598bacc`	1.58 MiB	2.13 MiB	557.33 KiB
`c357e8a`	1.58 MiB	2.13 MiB	557.38 KiB
`a110e56`	1.58 MiB	2.13 MiB	557.49 KiB
`d9d541c`	1.58 MiB	2.13 MiB	557.33 KiB
`e9c7b57`	1.58 MiB	2.13 MiB	557.34 KiB

Moved 'Support span envelope item type' feature to internal section.

sentry/src/main/java/io/sentry/SentryItemType.java

romtsn

LGTM, maybe create a followup issue to address the client reports/rate limiter concern?

github-actions · 2025-11-26T10:20:49Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-11-26T10:50:52Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-11-26T11:00:55Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

buenaflor · 2025-11-26T13:31:01Z

@romtsn updated the impl to handle span datacategory for client report / rate limiter as well

double checked relay and "span" datacategory is corret here

github-actions · 2025-11-26T14:37:15Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

romtsn

re-checked -- looks good!

github-actions · 2025-11-26T16:01:58Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

Support span type

82276e8

buenaflor requested review from adinauer, lcian, markushi, romtsn and stefanosiano as code owners November 25, 2025 12:22

buenaflor added 3 commits November 25, 2025 13:24

Update CHANGELOG

4a59c7b

Update CHANGELOG

1167819

Update CHANGELOG

39664b5

buenaflor commented Nov 25, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

sentry bot reviewed Nov 25, 2025

View reviewed changes

buenaflor added 2 commits November 25, 2025 15:44

Merge branch 'main' into feat/support-span-sentry-item-type

db9a241

Update CHANGELOG

71a1fa0

Moved 'Support span envelope item type' feature to internal section.

cursor bot reviewed Nov 25, 2025

View reviewed changes

sentry/src/main/java/io/sentry/SentryItemType.java Show resolved Hide resolved

sentry/src/main/java/io/sentry/SentryItemType.java Show resolved Hide resolved

romtsn approved these changes Nov 25, 2025

View reviewed changes

Add client report recorder and rate limiting case

65d8e80

Formatting

855d9f8

getsentry deleted a comment from github-actions bot Nov 26, 2025

Fix test

8628ab9

getsentry-bot and others added 2 commits November 26, 2025 10:52

Format code

f287714

Merge branch 'main' into feat/support-span-sentry-item-type

7860647

Merge branch 'main' into feat/support-span-sentry-item-type

7b0f12f

romtsn approved these changes Nov 26, 2025

View reviewed changes

Merge branch 'main' into feat/support-span-sentry-item-type

8d42537

buenaflor enabled auto-merge (squash) November 26, 2025 16:08

buenaflor merged commit fc5ccaf into main Nov 26, 2025
60 of 61 checks passed

buenaflor deleted the feat/support-span-sentry-item-type branch November 26, 2025 16:20

buenaflor mentioned this pull request Nov 27, 2025

[Span First]: Add new Span protocol getsentry/sentry-dart#3330

Closed

Uh oh!

Conversation

buenaflor commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

buenaflor Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

romtsn Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

buenaflor Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/support-span-sentry-item-type

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

romtsn left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 26, 2025 • edited by buenaflor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Nov 26, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Nov 26, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

buenaflor commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

romtsn left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 26, 2025 • edited by buenaflor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

buenaflor commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited by buenaflor

Loading

buenaflor commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited by buenaflor

Loading