feat(init): Log why a properties file was not loaded#4879
Conversation
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| 9fbb112 | 359.71 ms | 421.85 ms | 62.14 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| 674d437 | 355.28 ms | 504.18 ms | 148.90 ms |
| 604a261 | 380.65 ms | 451.27 ms | 70.62 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
| d5a29b6 | 298.62 ms | 391.78 ms | 93.16 ms |
| ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
| 27d7cf8 | 306.76 ms | 366.66 ms | 59.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| 674d437 | 1.58 MiB | 2.10 MiB | 530.94 KiB |
| 604a261 | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
| d5a29b6 | 1.58 MiB | 2.12 MiB | 549.37 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
* Trim whitespace on properties file path * format * changelog
| logger.log( | ||
| SentryLevel.ERROR, | ||
| "Failed to load Sentry configuration since it is not readable: %s", | ||
| filePath); |
There was a problem hiding this comment.
Bug: Whitespace Path Mismatch
The error messages log the original filePath which may contain whitespace, but the actual file check uses filePath.trim(). This creates confusing logs where the displayed path doesn't match the path that was actually checked, making debugging difficult when paths have leading or trailing whitespace.
|
How to disable the error messages (like |
|
@jeremyvdw sorry I missed this being used to look for a You may simply ignore the message for now. edit: here's a PR to fix this: #4929 |
|
@adinauer Thank you very much! |
|
@jeremyvdw the fix has landed in https://github.com/getsentry/sentry-java/releases/tag/8.27.1 |
📜 Description
Log why a properties file was not loaded, e.g. file not found, not a file or not readable
💡 Motivation and Context
Took me a while to figure out why my properties weren't working as expected.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps