Merged
Conversation
…inishes Removed few useless IO calls
stefanosiano
commented
Sep 12, 2025
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
| 9fbb112 | 359.71 ms | 421.85 ms | 62.14 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
markushi
approved these changes
Sep 29, 2025
romtsn
reviewed
Sep 29, 2025
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Outdated
Show resolved
Hide resolved
romtsn
requested changes
Sep 29, 2025
Member
romtsn
left a comment
There was a problem hiding this comment.
blocking so you don't accidentally merge since there's one approval already
# Conflicts: # sentry/src/main/java/io/sentry/SentryOptions.java
romtsn
reviewed
Oct 14, 2025
romtsn
reviewed
Oct 14, 2025
| SentryLevel.WARNING, | ||
| "Directory '%s' doesn't exist. No cached events to send.", | ||
| SentryLevel.ERROR, | ||
| "Cache dir %s is null or is not a directory.", |
Member
There was a problem hiding this comment.
so does listFiles have the isDirectory check under the hood?
Contributor
Author
There was a problem hiding this comment.
yep. From the javadoc
If this abstract pathname does not denote a directory, then this method returns null
romtsn
approved these changes
Oct 14, 2025
Member
romtsn
left a comment
There was a problem hiding this comment.
LGTM, thanks for introducing the wrapper!
Member
|
@stefanosiano I realized there's a couple of more cases which we didn't cover from the issue: Shall we also wrap them? |
8 tasks
Contributor
Author
Covered in #4809 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SentryAndroid.init now sets strictMode to Lax and reset it after it finishes
Removed few useless IO calls
💡 Motivation and Context
Closes #4261
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps