Prevent race condition in mixin installation #3503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This fixes an intermittent race condition that causes GitHub Actions builds to fail with the error:
The
GetMixins()mage target previously installed mixins in parallel usingerrgroup.Group. This caused multipleporter mixin installcommands to run concurrently, all attempting to read and write the samecache.jsonfile without synchronization.The
savePackageInfo()function performs read-modify-write operations oncache.jsonwithout file locking. When multiple processes write simultaneously, the file becomes corrupted with invalid JSON.Solution: Changed
GetMixins()to install mixins sequentially instead of in parallel, ensuring only one process accessescache.jsonat a time.What issue does it fix
This addresses an intermittent CI/CD failure that occurs during the "Configure Agent" step in GitHub Actions workflows when running
mage build.Notes for the reviewer
Checklist