Skip to content

Conversation

@HendrikStrobelt
Copy link
Contributor

  1. ctx.render_for_generation() used in generate calls 2) ctx.full_event_log() used for views on the whole context

also: fixed and inherent bug in m.chat which wrongly added the chat turn to the contexts (as single events, not as turn).

1) `ctx.render_for_generation()` used in generate calls
2) `ctx.full_event_log()` used for views on the whole context

also: fixed and inherent bug in `m.chat` which wrongly added the chat turn to the contexts (as single events, not as turn).
@nrfulton
Copy link
Member

also: fixed and inherent bug in m.chat which wrongly added the chat turn to the contexts (as single events, not as turn).

I want to revisit this.

My understand was that:

m.insert(instruction)
m.insert(modeloutputthunk)
m.ctx.last_turn()

should be the same as:

m.insert_turn(Turn(instruction, modeloutputthunk))
m.ctx.last_turn()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants