Gabrielcsapo/typescript conversion#89
Merged
gabrielcsapo merged 7 commits intogabrielcsapo:gabrielcsapo/typescript-conversionfrom Jan 3, 2022
Merged
Conversation
Replaced JavaScript with TypeScript in README Made sure that package will be built if installed from github Fixed some types Made some async functions return a Promise if callback was not specified
Added myself as contributor cuz y not
oops, missed a spot
this dotfile should be commited to the repo
.git-package.meta should not get committed to npm
gabrielcsapo
reviewed
Dec 4, 2021
| */ | ||
| export function parseGitName(repo: string): string { | ||
| const locationOfGit = repo.lastIndexOf('.git'); | ||
| return repo.substr(0, locationOfGit > 0 ? locationOfGit : repo.length); |
Owner
There was a problem hiding this comment.
why do we want to use slice here?
Contributor
Author
There was a problem hiding this comment.
String.substr is deprecated, so I replaced it with slice instead as with 0 being the first argument they're doing the same thing
gabrielcsapo
reviewed
Dec 4, 2021
| "coverage": "jest --coverage" | ||
| "build": "echo \"\" > ./build-complete.meta && tsc", | ||
| "coverage": "jest --coverage", | ||
| "install": "( [ -f ./git-package.meta ] && [ ! -f ./build-complete.meta ] && echo \"\" > ./build-complete.meta && npm install . && tsc ) || echo \"\" > ./build-complete.meta" |
Contributor
Author
There was a problem hiding this comment.
For some reason npm does not build any package installed from git, so I added this cos it was too annoying (however I forgot to delete dist while testing, so I noticed that it doesn't work only when I committed this)
Owner
|
Thank you for this! I just had a few questions! |
…ypescript-conversion
Owner
|
Thank you @5GameMaker, merged and going to publish a beta. |
gabrielcsapo
added a commit
that referenced
this pull request
Jan 3, 2022
* [wip] * [wip] migrates tests to jest for easier debugging, removes deps * [chore] ignore dist * [chore] fix ordering of event listeners to make sure async functions were run after * [chore] updates tests to be jest tests adds website scaffolding * [chore] updates ci workflow and cleans up website * [chore] get types building and docs produced * Gabrielcsapo/typescript conversion (#89) * Minor fixes Replaced JavaScript with TypeScript in README Made sure that package will be built if installed from github Fixed some types Made some async functions return a Promise if callback was not specified * Fixed small TYPO that broke README.md * Update package.json Added myself as contributor cuz y not * Update service.ts oops, missed a spot * Create .git-package.meta this dotfile should be commited to the repo * Create .npmignore .git-package.meta should not get committed to npm Co-authored-by: Buj Itself <buj351@outlook.com> Co-authored-by: Gabriel Csapo <gabecsapo@gmail.com> * [chore] updates dependencies * [chore] fixes node@14 tests * [chore] fix failing tests * [chore] fix failing tests * [chore] fix lint issues * [chore] updates changelog Co-authored-by: Buj <42136194+5GameMaker@users.noreply.github.com> Co-authored-by: Buj Itself <buj351@outlook.com>
gabrielcsapo
added a commit
that referenced
this pull request
Jan 25, 2022
* [wip] * [wip] migrates tests to jest for easier debugging, removes deps * [chore] ignore dist * [chore] fix ordering of event listeners to make sure async functions were run after * [chore] updates tests to be jest tests adds website scaffolding * [chore] updates ci workflow and cleans up website * [chore] get types building and docs produced * Gabrielcsapo/typescript conversion (#89) * Minor fixes Replaced JavaScript with TypeScript in README Made sure that package will be built if installed from github Fixed some types Made some async functions return a Promise if callback was not specified * Fixed small TYPO that broke README.md * Update package.json Added myself as contributor cuz y not * Update service.ts oops, missed a spot * Create .git-package.meta this dotfile should be commited to the repo * Create .npmignore .git-package.meta should not get committed to npm Co-authored-by: Buj Itself <buj351@outlook.com> Co-authored-by: Gabriel Csapo <gabecsapo@gmail.com> * [chore] updates dependencies * [chore] fixes node@14 tests * [chore] fix failing tests * [chore] fix failing tests * [chore] fix lint issues * [chore] updates changelog Co-authored-by: Buj <42136194+5GameMaker@users.noreply.github.com> Co-authored-by: Buj Itself <buj351@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.