Merged
Conversation
- adds extensive docs to Git, Util and Service - adds named function to events to trace errors more easily
Owner
Author
|
@echopoint @OmgImAlexis what do you guys think? |
Owner
Author
|
this should satisfy the original requirements of #26 |
Collaborator
|
Looks good to me. Check your # .. 26 is this pull #. ;) |
Collaborator
|
Bah spoke too soon. All http.ServerRequest type references should probably be http.IncomingMessage, depending on the context in which the variable is being assigned from. i.e. if the variable is the first parameter in the http.request event, then it should be an http.IncomingMessage instead. If the variable is assigned from the return of the http.request function, then it should be an http.ClientRequest type. ;) |
Closed
Owner
Author
|
@echopoint fixed 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@echopoint I finally got to it!
fixes #17