Listen needs an options object to be passed in#103
Closed
stevesouth wants to merge 1 commit intogabrielcsapo:mainfrom
Closed
Listen needs an options object to be passed in#103stevesouth wants to merge 1 commit intogabrielcsapo:mainfrom
stevesouth wants to merge 1 commit intogabrielcsapo:mainfrom
Conversation
Listen needs an options object to be passed in otherwise the callback won't be called.
Owner
|
I think we should update the underlying code to ensure a default option is passed. |
Owner
|
I fixed this in #88, options will by default set the server type to http |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listen needs an options object to be passed in otherwise the callback won't be called.