Merged
Conversation
dsyme
reviewed
Apr 5, 2017
| if isUnresolved() then makeReadOnlyCollection[] else | ||
|
|
||
| if entity.IsILEnumTycon then | ||
| let (TILObjectReprData(scoref,enc,tdef)) = entity.ILTyconInfo |
Contributor
There was a problem hiding this comment.
I think these next few lines can be replaced by a use of generalizeTyconRef?
dsyme
reviewed
Apr 5, 2017
| let formalTypeInst = generalizeTypars formalTypars | ||
| let ty = TType_app(entity,formalTypeInst) | ||
| let formalTypeInfo = ILTypeInfo.FromType cenv.g ty | ||
| tdef.Fields.AsList |
Contributor
There was a problem hiding this comment.
I think this can be done using GetILFieldInfosOfType on an infoReader, e.g. https://github.com/fsharp/FSharp.Compiler.Service/blob/0892b3c45ee4d3467a89e56b483919bb0271f5c2/src/fsharp/NicePrint.fs#L1491
(It's not too bad as is, but the uniform way is preferable)
dsyme
reviewed
Apr 5, 2017
| |> Seq.map(fun f -> f.Name, f.LiteralValue ) | ||
| |> Seq.toList)) | ||
|
|
||
| enums |> shouldEqual |
Member
Author
|
@dsyme Ok, I'll take a look at the suggestions a bit later in the week. |
Contributor
|
I'll merge now, since the test case is fine and the cleanup is easy later |
dsyme
added a commit
to dsyme/FSharp.Compiler.Service
that referenced
this pull request
Jun 28, 2017
properly integrate visualfsharp/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #658 including test