Merged
Conversation
|
This is great. I think the test will need to be Windows-only since peverify is not available on Mono? The Travis build may well fail (or, well, I hope so, otherwise there is something wrong with thte Travis build tests!) BTW it would be good to also patch up these to be cross-platform if you know how to do that: |
Contributor
Author
|
True, perhaps cecil might be a more appropriate choice for doing these tests. |
Contributor
Author
|
It seems that Travis is failing on account of me using named exception fields. Revisions need to made, I'll retract the pull request for now. |
Member
|
@dsyme Its |
Contributor
Author
|
Should work fine now with F# 3.0 compiler and mono. |
Contributor
Author
|
Travis passes now, should be ok. |
ghost
merged commit
|
Great job! |
dsyme
pushed a commit
to dsyme/FSharp.Compiler.Service
that referenced
this pull request
Jun 28, 2017
Try to clean up error text a little.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple test setting for running and verifying output from fsc. Included tests are very basic but it should be relatively to enrich.