tutorials: general container-only fixes#896
Merged
mike-scott merged 2 commits intofoundriesio:mainfrom Mar 6, 2026
Merged
Conversation
Member
Author
|
Converted to draft as I will cover other topics raised by Mike in this PR |
kprosise
approved these changes
Mar 6, 2026
Contributor
kprosise
left a comment
kprosise
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this!
vanmaegima
changed the title
mike-scott
approved these changes
Mar 6, 2026
Contributor
mike-scott
left a comment
mike-scott
left a comment
There was a problem hiding this comment.
Thank you for the quick fix @vanmaegima ! LGTM
mike-scott
requested changes
Mar 6, 2026
source/tutorials/customizing-the-platform/customizing-the-platform.rst
Outdated
Show resolved
Hide resolved
vanmaegima
force-pushed
the
get-started-fix
branch
from
ec01ec1 to
a4ae876
Compare
Member
Author
|
@mike-scott done |
mike-scott
approved these changes
Mar 6, 2026
Contributor
mike-scott
left a comment
mike-scott
left a comment
There was a problem hiding this comment.
Thanks for the changes. Looks great.
At this point, the user is not aware of how to configure new branches in a factory, so remove mentions to ``devel``. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Now that we support container-only factories, the registering process is specific for the factory type. We should point to both sources when mentioning the registered devices. Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
vanmaegima
force-pushed
the
get-started-fix
branch
from
a4ae876 to
d6a63e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this point, the user is not aware of how to configure new branches in a factory, so remove mentions to
devel.We should address creating new branches in a new tutorial, coming before
Working with Tags.Also handle the "Register Your Device" ambiguity based on the factory type.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Checklist
make linkcheck, and add redirects for any moved or deleted pages.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.