Adding Declarative to glossary #12981
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's glossary by introducing a comprehensive definition for the term "Declarative." This addition aims to clarify a core concept, particularly relevant to UI development and frameworks like Flutter, providing users with a better understanding of declarative programming principles and their application. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the term 'Declarative' to the glossary. The definition and related links are relevant and well-written. I've provided one suggestion to improve the conciseness of the long description by removing some redundant content. Overall, this is a good addition.
| Declarative programming is a style where you describe the | ||
| _current state_ of your UI, and the framework takes care | ||
| of transitioning the UI to match that state. | ||
| In Flutter, widgets are immutable "blueprints". | ||
| To change the UI, a widget triggers a rebuild on itself | ||
| (usually by calling `setState`) and constructs a new widget subtree. | ||
| This contrasts with _imperative_ programming, | ||
| where you manually construct and mutate UI entities. |
There was a problem hiding this comment.
The first paragraph of the long_description is redundant as it largely repeats the short_description. The long description should expand on the short one by providing more specific details. Removing the repetitive first paragraph makes the explanation more concise and focuses on the Flutter-specific implementation of the declarative pattern.
In Flutter, widgets are immutable "blueprints".
To change the UI, a widget triggers a rebuild on itself
(usually by calling `setState`) and constructs a new widget subtree.
This contrasts with _imperative_ programming,
where you manually construct and mutate UI entities.
There was a problem hiding this comment.
Bad bot, this long description adds useful context!
|
Visit the preview URL for this PR (updated for commit ecad0c1): https://flutter-docs-prod--pr12981-dependency-injection-sqsui8pr.web.app |
3 participants
As it says.