This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Reduce Android compiler warnings, prevent NPE#963
Merged
mklim merged 4 commits intoflutter:masterfrom Feb 22, 2019
Merged
Conversation
ened
force-pushed
the
firebase-auth-warnings
branch
from
145dc96 to
0873e4f
Compare
mklim
approved these changes
Feb 21, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM with one minor nit. Thanks for the contribution! If you don't have the time to keep working on this PR, please let us know and we can shepherd it forward.
|
|
||
| private void handleLinkWithEmailAndPassword( | ||
| MethodCall call, Result result, FirebaseAuth firebaseAuth) { | ||
| if (firebaseAuth.getCurrentUser() == null) { |
Contributor
There was a problem hiding this comment.
nit: Can we store this as a local variable so we don't need to fetch it again below? This applies to all of these safeguards.
ened
force-pushed
the
firebase-auth-warnings
branch
from
d756dd0 to
2748984
Compare
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Reduce Android compiler warnings, prevent NPE * Upgrade Android gradle plugin to 3.3.1 * Save few object allocations (nit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC for the FlutterFire team.
I understand that some plugin methods would not typically be called without a FirebaseUser instance, yet the plugin could should probably safeguard against misuse.
Also, as some of the type warnings caused unnecessary logs, I added annotations to prevent the warnings.