This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_android][webview_flutter_wkwebview] Adds support to retrieve native WebView#7071
Merged
auto-submit[bot] merged 14 commits intoflutter:mainfrom Feb 14, 2023
Merged
Conversation
github-actions
bot
added
p: webview_flutter
Contributor
Author
|
cc @jjliu15 @timothyhoang-google as a heads up |
packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FLTWebViewFlutterPlugin.h
Show resolved
Hide resolved
| */ | ||
| @SuppressWarnings("unused") | ||
| @Nullable | ||
| public static WebView getWebView(FlutterEngine engine, long identifier) { |
Contributor
There was a problem hiding this comment.
Putting the accessor on this class encourages people to view this whole class as public, stable API, which could easily lead to accidental breakage later. Can we make a new wrapper class to be the public API, with just this method?
stuartmorgan-g
suggested changes
Feb 10, 2023
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just comment nits and adding in the project changes; thanks for adding the wrapper!
...ndroid/src/main/java/io/flutter/plugins/webviewflutter/WebViewFlutterAndroidExternalApi.java
Show resolved
Hide resolved
...ebview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebViewFlutterWKWebViewExternalAPI.h
Show resolved
Hide resolved
...ebview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebViewFlutterWKWebViewExternalAPI.h
Outdated
Show resolved
Hide resolved
...bview_flutter_wkwebview/example/ios/RunnerTests/FWFWebViewFlutterWKWebViewExternalAPITests.m
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Feb 14, 2023
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with nits. Looks like you'll need to sync with main to pick up the new FTL key so CI passes.
...ebview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebViewFlutterWKWebViewExternalAPI.h
Outdated
Show resolved
Hide resolved
...ebview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebViewFlutterWKWebViewExternalAPI.h
Outdated
Show resolved
Hide resolved
...ebview_flutter/webview_flutter_wkwebview/ios/Classes/FWFWebViewFlutterWKWebViewExternalAPI.m
Outdated
Show resolved
Hide resolved
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2023
…upport to retrieve native `WebView` (flutter/plugins#7071)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2023
* 66d5724fa Revert "[camera] flip/change camera while recording (split out PR for cam_avfoundation and cam_android) (#7109)" (flutter/plugins#7181) * d2fba3822 [webview_flutter_android][webview_flutter_wkwebview] Adds support to retrieve native `WebView` (flutter/plugins#7071) * 7a7e43e79 [google_maps_flutter_android] Fixes initial padding not working while map has not been created yet. (flutter/plugins#7135) * 677b43ad9 [ci] Remove repo tooling (flutter/plugins#7172) * 2ce625f1a [cameraX] Add integration test for availableCameras (flutter/plugins#7156)
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of googleads/googleads-mobile-flutter#618
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.