This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[local_auth] Fix default deviceSupportsBiometrics#5321
Merged
fluttergithubbot merged 5 commits intoflutter:mainfrom Apr 22, 2022
Merged
Conversation
Fixes a regression from the federation of local_auth in the default method channel implementation of `deviceSupportsBiometrics`. It needs to use the unfiltered method channel list in order to work correctly, not the results of the Dart method that filterns out the sentinel for unenrolled devices. See flutter#5309 (comment) for context.
BeMacized
approved these changes
Apr 21, 2022
Contributor
BeMacized
left a comment
BeMacized
left a comment
There was a problem hiding this comment.
LGTM, of course assuming you remove the one now unused import in the test file that fails the analyzer checks.
Contributor
Author
|
Doh |
stuartmorgan-g
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from the federation of local_auth in the default
method channel implementation of
deviceSupportsBiometrics. It needs touse the unfiltered method channel list in order to work correctly, not
the results of the Dart method that filterns out the sentinel for
unenrolled devices.
Also adds some implementation comments about how this works, since
it's very non-obvious.
See #5309 (comment)
for context.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).