This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Migrate more integration tests to local web server#4987
Closed
stuartmorgan-g wants to merge 8 commits intoflutter:mainfrom
Closed
[webview_flutter] Migrate more integration tests to local web server#4987stuartmorgan-g wants to merge 8 commits intoflutter:mainfrom
stuartmorgan-g wants to merge 8 commits intoflutter:mainfrom
Conversation
11 tasks
Contributor
Author
|
AFAICT the issue here is that the webview delegate is sometimes (it doesn't happen for me locally) using the delegate from the example, not the test, which suggest there's some kind of race condition and state bleed here. I have no idea why that would be happening though. |
Contributor
Author
|
I've split video_player changes into #5103 to unblock those. |
Contributor
Author
|
Closing until I have time to revisit this and figure out what's going on with the delegate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces youtube.com URLs in integration tests with URLs using the local web server
running inside of the integration test.
No CHANGELOG change: Only internal test details are changing
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).