Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Comments

[camera_web] Add initializeCamera implementation#4186

Merged
fluttergithubbot merged 7 commits intoflutter:masterfrom
VeryGoodOpenSource:feat/camera-web-initialize-camera
Jul 24, 2021
Merged

[camera_web] Add initializeCamera implementation#4186
fluttergithubbot merged 7 commits intoflutter:masterfrom
VeryGoodOpenSource:feat/camera-web-initialize-camera

Conversation

@bselwe
Copy link
Contributor

@bselwe bselwe commented Jul 23, 2021 •
edited
Loading

Adds initializeCamera implementation of the camera platform interface.

  • Added getVideoSize to Camera.
    • Returns a size of the camera video based on its first video track size.
  • Added initializeCamera and onCameraInitialized implementation.
    • Initializes and starts playing the camera stream.
    • Adds a CameraInitializedEvent to the camera events stream controller. The event is emitted on the onCameraInitialized stream and includes a camera id, video size, default exposure and focus modes (auto).
  • Replaced an HTTP stream with a blank canvas stream in tests that use a video element. In this way, tests are not reliant on the network and the video size can be easily adjusted.

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe bselwe requested a review from bparrishMines as a code owner July 23, 2021 11:37
@google-cla google-cla bot added the cla: yes label Jul 23, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Jul 23, 2021

@ditman @felangel @orestesgaolin

bselwe
bselwe commented Jul 23, 2021
View reviewed changes
packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart Outdated
/// [imageFormatGroup] is used to specify the image formatting used.
/// On Android this defaults to ImageFormat.YUV_420_888 and applies only to the imageStream.
/// On iOS this defaults to kCVPixelFormatType_32BGRA.
/// On Web this parameter is currently not supported.
Copy link
Contributor Author

@bselwe bselwe Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ditman Should this be reverted for now?

Copy link
Member

@ditman ditman Jul 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, let's add a pass documenting all the web stuff in platform_interface later on, since we need to publish a new version of the platform_interface so the new docs show up in pub.

@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 23, 2021
ditman
ditman approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Let's go!

packages/camera/camera_web/example/integration_test/camera_test.dart
..width = 10
..height = 10;

final videoElement = getVideoElementWithBlankStream(Size(10, 10));
Copy link
Member

@ditman ditman Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yes, this is great!

@ditman

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 23, 2021
@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 23, 2021
@fluttergithubbot fluttergithubbot merged commit 400fa20 into flutter:master Jul 24, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
400fa20 [camera_web] Add initializeCamera implementation (flutter/p…
ca1b499 
…lugins#4186)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
400fa20 [camera_web] Add initializeCamera implementation (flutter/p…
521c07e 
…lugins#4186)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
400fa20 [camera_web] Add initializeCamera implementation (flutter/p…
68bf477 
…lugins#4186)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bselwe @fotiDim
[camera_web] Add initializeCamera implementation (flutter#4186)
63ebb90
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @amantoux
[camera_web] Add initializeCamera implementation (flutter#4186)
fb8808d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bselwe @ditman @fluttergithubbot