This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in] Fix Exception leaking in debug mode (#64681)#2971
Closed
feinstein wants to merge 1 commit intoflutter:masterfrom
Closed
[google_sign_in] Fix Exception leaking in debug mode (#64681)#2971feinstein wants to merge 1 commit intoflutter:masterfrom
feinstein wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
|
@mehmetf could you help me figure out what's the problem with the tests? |
Contributor
|
All of the referenced issues are closed, referring to an issue that was recently fixed in the Dart VM. Given that, is this PR still necessary? |
Contributor
|
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
Contributor
Author
|
Sorry Stuart, I forgot to reply... Yeah I don't think it's necessary anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is related to flutter/flutter#26705 and many others. I already fixed this before on flutter/flutter#37343 submitting this PR #1937.
I am fixing this again.
Could the owners of these files make some sort of mechanism to avoid this from happening again?
I need some help with the tests, I honestly don't understand why the
'can sign in after init failed before'test is failing. For some reason theMockMethodCallHandleris only being called once. I didn't change anything on this test (just syntactic sugar, but it also fails if I remove it).Related Issues
Fixes flutter/flutter#64681
Fixes flutter/flutter#45146
flutter/flutter#37343
flutter/flutter#26705
dart-lang/sdk#37268
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?