This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Fix double tap on resize issue#1965
Merged
mklim merged 1 commit intoflutter:masterfrom Aug 10, 2019
mklim:webview_input_drop
Merged
[webview_flutter] Fix double tap on resize issue#1965mklim merged 1 commit intoflutter:masterfrom mklim:webview_input_drop
mklim merged 1 commit intoflutter:masterfrom
mklim:webview_input_drop
Conversation
amirh
approved these changes
Aug 9, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
LGTM
Let's file an issue tracking the auto suggestions issue
WebView is incorrectly dropping some input events as unhandled. Previously we were restarting the input connection to try and work around this, but that causes a long tail of bugs in various SDK and WebView versions. Stop the events from bubbling instead since they still appear to be correctly handled despite being marked wrong. Long term we should figure out why this is happening in WebView and figure out a deeper fix for this issue, but this workaround solves the linked bugs in the immediate short term.
Contributor
Author
|
Filed flutter/flutter#37989. |
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
WebView is incorrectly dropping some input events as unhandled. Previously we were restarting the input connection to try and work around this, but that causes a long tail of bugs in various SDK and WebView versions. Stop the events from bubbling instead since they still appear to be correctly handled despite being marked wrong. Long term we should figure out why this is happening in WebView and figure out a deeper fix for this issue, but this workaround solves the linked bugs in the immediate short term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WebView is incorrectly dropping some input events as unhandled.
Previously we were restarting the input connection to try and work
around this, but that causes a long tail of bugs in various SDK and
WebView versions. Stop the events from bubbling instead since they still
appear to be correctly handled despite being marked wrong.
Long term we should figure out why this is happening in WebView and
figure out a deeper fix for this issue, but this workaround solves the
linked bugs in the immediate short term.
Related Issues
Fixes flutter/flutter#36978.
Fixes flutter/flutter#35867.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?