This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_admob] Banner Ad Horizontal Positioning#1925
Merged
bparrishMines merged 3 commits intoflutter:masterfrom Aug 16, 2019
malsabbagh:master
Merged
[firebase_admob] Banner Ad Horizontal Positioning#1925bparrishMines merged 3 commits intoflutter:masterfrom malsabbagh:master
bparrishMines merged 3 commits intoflutter:masterfrom
malsabbagh:master
Conversation
Adding the ability to horizontally adjust the ads location by specifying an offset from the centre.
Contributor
Author
|
Hey @amirh & @bparrishMines, Do you think this would be merged or there are plans that would affect this behaviour to prevent it from being merged in the future? It will be nice to have this as part of the next firebase_admob update. Thanks, |
bparrishMines
approved these changes
Aug 16, 2019
Contributor
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the contribution!
13 tasks
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to horizontally adjust the ads banner location by specifying an offset from the centre.
Description
The current behaviour allows the user only to specify an anchor top or bottom with an offset from the anchor. But it doesn't allow an offset from the horizontal centre. This PR will add that ability.
The motivation behind the change is to support split screen layout for tablets where ads banner could reside on one side of the screen.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?