This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_auth] Fixes exceptions when signing in on iOS#1921
Merged
collinjackson merged 11 commits intoflutter:masterfrom Jul 28, 2019
Merged
[firebase_auth] Fixes exceptions when signing in on iOS#1921collinjackson merged 11 commits intoflutter:masterfrom
collinjackson merged 11 commits intoflutter:masterfrom
Conversation
…uth_additional_null
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
* Fixes exceptions when signing in on iOS * Update test results to reflect different behavior on iOS and Android * Sign out at the start of tests
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Fixes exceptions when signing in on iOS * Update test results to reflect different behavior on iOS and Android * Sign out at the start of tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoids an exception when
additionalProviderInfoisnilor hasnilfields.Related Issues
Fixes flutter/flutter#37133
This is already tested by our integration tests, but our test CI isn't failing on exceptions that kill the app on iOS, which is how this slipped through. Once that is fixed, test failures like this will prevent PRs from being merged. (flutter/flutter#37141, https://github.com/flutter/plugin_tools/pull/50)
For the moment we can confirm that the test failure is fixed by just looking at the test logs.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?